Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

Merged
merged 3 commits into from
Nov 2, 2024
Merged

python312Packages.gradio: 4.44.1 -> 5.1.0 #349625

merged 3 commits into from
Nov 2, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Oct 18, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review October 18, 2024 20:28
@pbsbot
Copy link

pbsbot commented Oct 18, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

x86_64-linux

❌ 2 packages failed to build:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 19, 2024
@pbsds
Copy link
Member Author

pbsds commented Oct 22, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

@pbsds pbsds requested a review from GaetanLepage October 22, 2024 17:33
GaetanLepage
GaetanLepage approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
If you have the patience, maybe go with:

  • getting rid of with lib; in the meta attrs
  • nativeBuildInputs -> build-system in gradio

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

x86_64-linux

❌ 2 packages failed to build:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 22, 2024
@pbsds pbsds force-pushed the bump-gradio-1729275338 branch from 39ae9c1 to c521a1e Compare October 26, 2024 06:44
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024
@pbsds pbsds force-pushed the bump-gradio-1729275338 branch 2 times, most recently from b84126f to 9f38be9 Compare October 26, 2024 16:18
GaetanLepage
GaetanLepage approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

x86_64-linux

❌ 6 packages failed to build:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

x86_64-darwin

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

@GaetanLepage
Copy link
Contributor

Failures are unrelated. Feel free to merge :)

@pbsds
Copy link
Member Author

pbsds commented Oct 29, 2024

will have to wait for stable branch-off

@fabaff
Copy link
Member

fabaff commented Oct 31, 2024 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

x86_64-linux

❌ 10 packages failed to build:
  • private-gpt
  • private-gpt.dist
  • python311Packages.gradio
  • python311Packages.gradio.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.gradio
  • python312Packages.gradio.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 8 packages built:
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
       > Checking runtime dependencies for gradio-5.1.0-py3-none-any.whl
       >   - aiofiles<24.0,>=22.0 not satisfied by version 24.1.0
       >   - markupsafe~=2.0 not satisfied by version 3.0.1

Unfortunately an update to 5.4.0 will not help much. Looks like we need to add pythonRelaxDeps.

@fabaff fabaff mentioned this pull request Oct 31, 2024
Merged
13 tasks
@pbsds pbsds mentioned this pull request Nov 1, 2024
Merged
13 tasks
@pbsds pbsds force-pushed the bump-gradio-1729275338 branch from 9f38be9 to 5f3c27a Compare November 1, 2024 15:19
@pbsds
Copy link
Member Author

pbsds commented Nov 1, 2024

fixed it here, but since the bump is a breaking change, i also made #352893

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349625

x86_64-linux

❌ 6 packages failed to build:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

x86_64-darwin

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

aarch64-darwin

⏩ 6 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
✅ 12 packages built:
  • python311Packages.gradio
  • python311Packages.gradio-client
  • python311Packages.gradio-client.dist
  • python311Packages.gradio-pdf
  • python311Packages.gradio-pdf.dist
  • python311Packages.gradio.dist
  • python312Packages.gradio
  • python312Packages.gradio-client
  • python312Packages.gradio-client.dist
  • python312Packages.gradio-pdf
  • python312Packages.gradio-pdf.dist
  • python312Packages.gradio.dist

GaetanLepage
GaetanLepage approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private-gpt failures are surely unrelated.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@GaetanLepage GaetanLepage merged commit cfc2393 into NixOS:master Nov 2, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbsds @pbsbot @GaetanLepage @fabaff @wegank